[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] libqtest: New hmp() & friends
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] libqtest: New hmp() & friends |
Date: |
Fri, 18 Sep 2015 09:47:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/18/2015 06:00 AM, Markus Armbruster wrote:
> New convenience function hmp() to facilitate use of
> human-monitor-command in tests. Use it to simplify its existing uses.
>
> To blend into existing libqtest code, also add qtest_hmpv() and
> qtest_hmp(). That, and the egregiously verbose GTK-Doc comment format
> make this patch look bigger than it is.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/drive_del-test.c | 22 ++++++----------------
> tests/ide-test.c | 8 ++------
> tests/libqtest.c | 35 +++++++++++++++++++++++++++++++++++
> tests/libqtest.h | 33 +++++++++++++++++++++++++++++++++
> 4 files changed, 76 insertions(+), 22 deletions(-)
>
> @@ -774,6 +801,14 @@ void qmp_discard_response(const char *fmt, ...)
> qtest_qmpv_discard_response(global_qtest, fmt, ap);
> va_end(ap);
> }
> +char *hmp(const char *fmt, ...)
> +{
> + va_list ap;
> +
> + va_start(ap, fmt);
> + return qtest_hmpv(global_qtest, fmt, ap);
> + va_end(ap);
Umm, that isn't quite what you meant :)
With the dead code after return fixed,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 7/7] tests: Simplify how qom-test is run, (continued)
[Qemu-devel] [PATCH 4/7] qmp: Fix device-list-properties not to crash for abstract device, Markus Armbruster, 2015/09/18
[Qemu-devel] [PATCH 1/7] libqtest: Clean up unused QTestState member sigact_old, Markus Armbruster, 2015/09/18
[Qemu-devel] [PATCH 2/7] libqtest: New hmp() & friends, Markus Armbruster, 2015/09/18
- Re: [Qemu-devel] [PATCH 2/7] libqtest: New hmp() & friends,
Eric Blake <=
[Qemu-devel] [PATCH 3/7] device-introspect-test: New, covering device introspection, Markus Armbruster, 2015/09/18
[Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices, Markus Armbruster, 2015/09/18