[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] qmp: Fix device-list-properties not to cras
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] qmp: Fix device-list-properties not to crash for abstract device |
Date: |
Fri, 18 Sep 2015 09:58:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/18/2015 06:00 AM, Markus Armbruster wrote:
> Broken in commit f4eb32b "qmp: show QOM properties in
> device-list-properties", v2.1.
>
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qmp.c | 6 ++++++
> tests/device-introspect-test.c | 11 ++++-------
> 2 files changed, 10 insertions(+), 7 deletions(-)
>
> +++ b/tests/device-introspect-test.c
> @@ -45,13 +45,10 @@ static void test_one_device(const char *type)
> QDict *resp;
> char *help;
>
> - /* FIXME device-list-properties crashes for abstract device, skip */
> - if (strcmp(type, "device")) {
Ah, this answers part of my confusion on 3/7. I was looking for so
condition on 'abstract', but the skip was based on a condition on
'device' (which happens to be abstract). Don't know if a different
wording on that comment would help; maybe:
FIXME device-list-properties crashes for device, because it is abstract;
skip
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] Fix device introspection regressions, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PATCH 4/7] qmp: Fix device-list-properties not to crash for abstract device, Markus Armbruster, 2015/09/18
- Re: [Qemu-devel] [PATCH 4/7] qmp: Fix device-list-properties not to crash for abstract device,
Eric Blake <=
- [Qemu-devel] [PATCH 1/7] libqtest: Clean up unused QTestState member sigact_old, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PATCH 2/7] libqtest: New hmp() & friends, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PATCH 3/7] device-introspect-test: New, covering device introspection, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PATCH 5/7] qdev: Protect device-list-properties against broken devices, Markus Armbruster, 2015/09/18