qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/4] utils: rename strtosz to use qemu prefix


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 1/4] utils: rename strtosz to use qemu prefix
Date: Fri, 18 Sep 2015 09:03:04 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 09/18/2015 04:59 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> 

No cover letter? No description of what changed since v1? It's generally
nice to include a 0/4 letter when sending a series; with new enough git,
'git config format.coverLetter auto' does what you want.

> Not only it makes sense, but it gets rid of checkpatch warning:
> WARNING: consider using qemu_strtosz in preference to strtosz
> 
> Also remove the tabs to please checkpatch.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Fortunately, this still stands.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]