Re: [Qemu-devel] [PATCH] target-arm: implement arm_debug_target_el()

[Edgar E. Iglesias]

On Fri, Sep 18, 2015 at 05:35:07PM +0100, Peter Maydell wrote:
> On 18 September 2015 at 17:15, Sergey Fedorov <address@hidden> wrote:
> > On 18.09.2015 18:57, Sergey Fedorov wrote:
> >> On 18.09.2015 17:11, Peter Maydell wrote:
> >>> On 18 September 2015 at 15:08, Peter Maydell <address@hidden> wrote:
> >>>> On 14 September 2015 at 11:53, Sergey Fedorov <address@hidden> wrote:
> >>>>> Implement debug exception routing according to ARM ARM D2.3.1 Pseudocode
> >>>>> description of routing debug exceptions.
> >>>>>
> >>>>> Signed-off-by: Sergey Fedorov <address@hidden>
> >>>>
> >>>> Applied to target-arm.next, thanks.
> >>> ...except it doesn't compile, because we don't have an env->cp15.mdcr_el2.
> >>> Presumably there's some other patch this depends on which you haven't
> >>> submitted yet?
> >>>
> >> Hm... I'll check it :)
> >
> > Sorry, I forgot to check that, but actually this patch depends on
> > another two patches in my local repository. Should I prepare MDCR_EL2
> > patch suitable for mainline or I can just remove this check from
> > arm_debug_target_el()?
> 
> Edgar, do you have a MDCR_EL2 implementation in your tree?
> 
> Otherwise, yes, Sergey, you should provide an MDCR_EL2/HDCR patch
> for mainline I think. It should be fairly easy as it just needs
> to be readable/writable and have the correct access checks.
> Don't forget to provide the AArch32 interface as well as the AArch64
> one, and the "RES0 if EL3 but not EL2" version.
> (See Edgar's recent patches in master for VMPIDR_EL2, VTCR_EL2,
> etc for examples.)

Hi,

Sorry, no, I only have a dummy for MDCR_EL2.. Would be great if Sergey has
something ready.

Best regards,
Edgar