Re: [Qemu-devel] [PATCH 0/6] machine: Deprecate machine_init()

[Eduardo Habkost]

On Sat, Sep 19, 2015 at 05:36:37PM +0200, Andreas Färber wrote:
> Hello,
> 
> Based on my pending qom-next pull, this series continues Eduardo's machine 
> cleanups.
> Having eliminated QEMUMachine and qemu_machine_register(), this series 
> eliminates
> machine_init() and MODULE_INIT_MACHINE.
> 
> As a side effect a few non-machine callers had to be updated, mostly for 
> QemuOpts.
> 
> It goes on to update Exynos4 machines for QOM, demonstrating that 
> DEFINE_MACHINE()
> can be inferior to inlining the QOM boilerplate code in case of multiple 
> machines.

Marcel once asked me if we could call DEFINE_MACHINE something like
DEFINE_SIMPLE_MACHINE, to clarify that it's supposed to be used only on
very simple cases that don't require anything except initializing some
MachineClass fields.

Initially, I assumed that almost every machine class would use
DEFINE_MACHINE, but then I noticed that it is not enough when one extra
inheritance level or a different class_size is involved. So I think
Marcel was right and we could rename DEFINE_MACHINE to
DEFINE_SIMPLE_MACHINE.

> 
> Independently, I noticed a nit in the PC machine macro I'm touching that could
> probably even be cherry-picked.

Thanks!

-- 
Eduardo