[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log |
Date: |
Mon, 21 Sep 2015 23:44:38 +0200 |
Hi
On Mon, Sep 21, 2015 at 9:29 PM, Michael S. Tsirkin <address@hidden> wrote:
>> Can this be considered a future enhancement?
>
> What's the big issue? Just count the devices that need a shared one, if
> that count is 0 reallocate with shared == false.
But then it should also VHOST_SET_LOG_BASE all the other devices with
the new log, unless you want to tackle only the future log users. So
it needs to track all the users of the log. Is there a clear benefit
of this? since the memory isn't shared without the memfd passed to
another process and the overhead of memfd is probably quite small, and
pre-shm or future resize will not use the shared memory already.
--
Marc-André Lureau
- [Qemu-devel] [PATCH v4 01/22] vhost-user: refactor ioctl translation, (continued)
- [Qemu-devel] [PATCH v4 01/22] vhost-user: refactor ioctl translation, marcandre . lureau, 2015/09/19
- [Qemu-devel] [PATCH v4 02/22] vhost-user: add protocol feature negotiation, marcandre . lureau, 2015/09/19
- [Qemu-devel] [PATCH v4 03/22] vhost-user: unit test for new messages, marcandre . lureau, 2015/09/19
- [Qemu-devel] [PATCH v4 04/22] configure: probe for memfd, marcandre . lureau, 2015/09/19
- [Qemu-devel] [PATCH v4 05/22] util: add linux-only memfd fallback, marcandre . lureau, 2015/09/19
- [Qemu-devel] [PATCH v4 06/22] util: add memfd helpers, marcandre . lureau, 2015/09/19
- [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log, marcandre . lureau, 2015/09/19
- Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log, Michael S. Tsirkin, 2015/09/21
- Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log, Marc-André Lureau, 2015/09/21
- Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log, Michael S. Tsirkin, 2015/09/21
- Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log,
Marc-André Lureau <=
- Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log, Michael S. Tsirkin, 2015/09/22
- Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log, Marc-André Lureau, 2015/09/22
- Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log, Michael S. Tsirkin, 2015/09/22
- Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log, Marc-André Lureau, 2015/09/22
- Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log, Michael S. Tsirkin, 2015/09/22
[Qemu-devel] [PATCH v4 08/22] vhost: document log resizing, marcandre . lureau, 2015/09/19
[Qemu-devel] [PATCH v4 09/22] vhost: use a function for each call, marcandre . lureau, 2015/09/19