qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 09/14] block: Add block job transactions


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v6 09/14] block: Add block job transactions
Date: Tue, 22 Sep 2015 10:32:25 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, 09/21 19:23, John Snow wrote:
> >  void block_job_completed(BlockJob *job, int ret)
> >  {
> >      BlockDriverState *bs = job->bs;
> > @@ -98,8 +191,13 @@ void block_job_completed(BlockJob *job, int ret)
> >      assert(!job->completed);
> >      job->completed = true;
> >      job->ret = ret;
> > -    job->cb(job->opaque, ret);
> > -    block_job_unref(job);
> > +    if (!job->txn) {
> > +        block_job_completed_single(job);
> > +    } else if (ret < 0 || block_job_is_cancelled(job)) {
> > +        block_job_completed_txn_abort(job);
> > +    } else {
> 
> over here it just appears we assert that ret is simply greater than or
> equal to zero.

Yeah, I don't think we have any possible positive ret value.

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]