qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project


From: Marc-André Lureau
Subject: Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project
Date: Tue, 22 Sep 2015 13:25:04 +0200

Hi

On Tue, Sep 22, 2015 at 1:06 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 30/08/2015 13:29, address@hidden wrote:
>> From: Marc-André Lureau <address@hidden>
>>
>> As previously discussed in the thread "libcacard: use the library?",
>> make libcacard a standalone library and use it if --enable-smartcard.
>>
>> I made the following repo out of a qemu filter-branch and added autofoo
>> build-sys: https://github.com/elmarco/libcacard. Since the original qemu
>> git tags are there, I think the first release version should be v2.5,
>> but there is no need to follow the same versions as qemu later on.
>>
>> libcacard could use the same infrastructure as the qemu project (mailing
>> list, git server, reviews etc). I have some experience with libcacard,
>> and I would be willing to maintain it, however I don't expect to do
>> more development with it in the near future.
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>
> I tested I could build QEMU with smartcard support after installing
> Fedora's libcacard-devel from QEMU 2.4, and "ldd" points to
> /lib64/libcacard.so.0.
>
> So, at least for Fedora users, there is no dependency on the distro
> packaging the new standalone libcacard.
>
> Just a small nit:
>
> diff --git a/configure b/configure
> index 6eb553c..0cb88c4 100755
> --- a/configure
> +++ b/configure
> @@ -3863,11 +3863,12 @@ if test "$smartcard" != "no"; then
>          libcacard_libs=$($pkg_config --libs libcacard)
>          QEMU_CFLAGS="$QEMU_CFLAGS $libcacard_cflags"
>          libs_softmmu="$libs_softmmu $libcacard_libs"
> +        smartcard="yes"
>      else
> -        if test "$libcacard" = "yes"; then
> -            feature_not_found "libcacard" "Install libcacard devel"
> +        if test "$smartcard" = "yes"; then
> +            feature_not_found "smartcard" "Install libcacard-devel"
>          fi
> -        libcacard="no"
> +        smartcard="no"
>      fi
>  fi
>

Oops, thanks for checking! I am sending a non-RFC version with this fixed.



-- 
Marc-André Lureau



reply via email to

[Prev in Thread] Current Thread [Next in Thread]