Re: [Qemu-devel] [PATCH v5 19/38] block: Fail requests to empty BlockBackend

[Kevin Wolf]

Am 22.09.2015 um 17:05 hat Max Reitz geschrieben:
> On 22.09.2015 16:30, Kevin Wolf wrote:
> > Am 18.09.2015 um 17:22 hat Max Reitz geschrieben:
> >> If there is no BlockDriverState in a BlockBackend or if the tray of the
> >> guest device is open, fail all requests (where that is possible) with
> >> -ENOMEDIUM.
> >>
> >> The reason the status of the guest device is taken into account is
> >> because once the guest device's tray is opened, any request on the same
> >> BlockBackend as the guest uses should fail. If the BDS tree is supposed
> >> to be usable even after ejecting it from the guest, a different
> >> BlockBackend must be used.
> >>
> >> Signed-off-by: Max Reitz <address@hidden>
> >> Reviewed-by: Eric Blake <address@hidden>
> > 
> > Do we want to include blk_drain() to make it a no-op instead of
> > crashing?
> 
> Yes, we do, so that would be in patch 20. Thanks for catching that.
> 
> > Also, we're now introducing BlockAIOCBs with a NULL bs with your use of
> > abort_aio_request. I haven't carefully reviewed the implications of this
> > yet, but that should definitely be done before we merge the series.
> 
> That should be patch 12.

Yes, you caught me reviewing just correctness, but not completeness of
patch 12.

Kevin

pgp4Wkq6o5dX9.pgp
Description: PGP signature