[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transa
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions |
Date: |
Tue, 22 Sep 2015 10:03:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/21/2015 08:46 PM, Fam Zheng wrote:
> From: Stefan Hajnoczi <address@hidden>
>
> Join the transaction when the 'transactional-cancel' QMP argument is
> true.
>
> This ensures that the sync bitmap is not thrown away if another block
> job in the transaction is cancelled or fails. This is critical so
> incremental backup with multiple disks can be retried in case of
> cancellation/failure.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> +++ b/qapi/block-core.json
> @@ -735,7 +735,6 @@
> # @on-target-error: #optional the action to take on an error on the target,
> # default 'report' (no limitations, since this applies to
> # a different block device than @device).
> -#
> # Note that @on-source-error and @on-target-error only affect background I/O.
> # If an error occurs during a guest write request, the device's rerror/werror
> # actions will be used.
Spurious line deletion when addressing review comment. Maintainer can
touch it up for the pull request, so my R-b still stands.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v7 05/14] blockjob: Introduce reference count, (continued)
- [Qemu-devel] [PATCH v7 05/14] blockjob: Introduce reference count, Fam Zheng, 2015/09/21
- [Qemu-devel] [PATCH v7 06/14] blockjob: Add .commit and .abort block job actions, Fam Zheng, 2015/09/21
- [Qemu-devel] [PATCH v7 07/14] blockjob: Add "completed" and "ret" in BlockJob, Fam Zheng, 2015/09/21
- [Qemu-devel] [PATCH v7 08/14] blockjob: Simplify block_job_finish_sync, Fam Zheng, 2015/09/21
- [Qemu-devel] [PATCH v7 09/14] block: Add block job transactions, Fam Zheng, 2015/09/21
- [Qemu-devel] [PATCH v7 10/14] blockdev: make BlockJobTxn available to qmp 'transaction', Fam Zheng, 2015/09/21
- [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions, Fam Zheng, 2015/09/21
- Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions, John Snow, 2015/09/22
- Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions, Eric Blake, 2015/09/22
- Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions, John Snow, 2015/09/22
- Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions, Markus Armbruster, 2015/09/23
- Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions, John Snow, 2015/09/23
- Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions, Markus Armbruster, 2015/09/24
- Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions, John Snow, 2015/09/25
[Qemu-devel] [PATCH v7 12/14] iotests: 124 - transactional failure test, Fam Zheng, 2015/09/21
[Qemu-devel] [PATCH v7 13/14] qmp-commands.hx: Update the supported 'transaction' operations, Fam Zheng, 2015/09/21
[Qemu-devel] [PATCH v7 14/14] tests: add BlockJobTxn unit test, Fam Zheng, 2015/09/21