[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disabl
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disable/enable a specific virt queue. |
Date: |
Tue, 22 Sep 2015 20:06:58 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/22/2015 08:05 PM, Yuanhan Liu wrote:
>>> + * VHOST_USER_SET_VRING_ENABLE
>>> +
>>> + Id: 18
>>> + Equivalent ioctl: N/A
>>> + Master payload: vring state description
>>> +
>>> + Signal slave to enable or disable corresponding vring.
>>
>> Does there need to be any QMP control to manually change a given queue,
>> or is it all used under the hood with no need for management apps to
>> care other than their initial request of max queues?
>
> TBH, I don't know. As far as I know, there is only one queue pair will
> be enabled by default, and it's user's job to enable (or disable) more
> queue pairs, say, by ethtool:
>
> # ethtool -L eth0 combined <queue pair number>
>
> Which ends up sending the VHOST_USER_SET_VRING_ENABLE to actually enable
> (or disable) a specific queue pairs.
So if I'm understanding, it is ethtool, not qemu, that is used to turn
on additional queues, and therefore we don't need a QMP command in qemu
to control things.
>
> Does that answer your question?
I think so, but I'll let other reviewers more familiar with this area of
code give a final say.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v10 1/7] vhost-user: use VHOST_USER_XXX macro for switch statement, (continued)
- [Qemu-devel] [PATCH v10 1/7] vhost-user: use VHOST_USER_XXX macro for switch statement, Yuanhan Liu, 2015/09/18
- [Qemu-devel] [PATCH v10 2/7] vhost-user: add protocol feature negotiation, Yuanhan Liu, 2015/09/18
- [Qemu-devel] [PATCH v10 4/7] vhost-user: add VHOST_USER_GET_QUEUE_NUM message, Yuanhan Liu, 2015/09/18
- [Qemu-devel] [PATCH v10 5/7] vhost: introduce vhost_backend_get_vq_index method, Yuanhan Liu, 2015/09/18
- [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disable/enable a specific virt queue., Yuanhan Liu, 2015/09/18
[Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support, Yuanhan Liu, 2015/09/18
Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support, Michael S. Tsirkin, 2015/09/22
Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support, Eric Blake, 2015/09/22
Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support, Eduardo Habkost, 2015/09/22