Re: [Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks

[Pavel Dovgaluk]

> From: Paolo Bonzini [mailto:address@hidden
> On 17/09/2015 18:24, Pavel Dovgalyuk wrote:
> > +        if ((now < last || now > (last + get_max_clock_jump()))
> > +            && replay_mode == REPLAY_MODE_NONE) {
> >              notifier_list_notify(&clock->reset_notifiers, &now);
> 
> This seems wrong.  You will have different timers in the record and the
> replay if you do not invoke e.g. rtc_notify_clock_reset.

That will "work" - record and replay will be equivalent.
But they will differ from normal mode. It'll better remove it from the patch.

Pavel Dovgalyuk