[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] qapi: convert NumaOptions into a flat un
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] qapi: convert NumaOptions into a flat union |
Date: |
Wed, 23 Sep 2015 08:40:05 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/23/2015 08:27 AM, Kővágó, Zoltán wrote:
> Changes the NumaOptions to flat union from a simple one. This is
> required by my later OptsVisitor patch to preserve backward
> compatibility.
>
> Strictly speaking this would break QMP compatibility (as specified in
> docs/qapi-code-gen.txt), but since no QMP command use this structure,
> it's not an issue. The -numa option syntax doesn't change. There are
> some changes in the C api, but this patch fixes them.
>
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
>
> ---
>
> Changes from v1:
> * fixed documentation
Since you're basing this on top of my pending series, why not take
advantage of it...
> +##
> +# @NumaCommonOptions
> +#
> +# Common set of numa options.
> +#
> +# @type: NUMA command-line option type.
> +#
> +# Since: 2.5
> +##
> +{ 'struct': 'NumaCommonOptions',
> + 'data': {
> + 'type': 'NumaOptionType' } }
...by dropping this type, and instead...
> +
> +##
> +# @NumaOptions
> +#
...document @type here, and...
> +# A discriminated record of NUMA options. (for OptsVisitor)
> +#
> +# Since 2.1
> +##
> +{ 'union': 'NumaOptions',
> + 'base': 'NumaCommonOptions',
...write this as 'base': { 'type': 'NumaOptionType' },
> + 'discriminator': 'type',
> + 'data': {
> + 'node': 'NumaNodeOptions' }}
> +
> +##
> # @HostMemPolicy
> #
> # Host memory policy types
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/3] qapi-flattening and preparation of -audiodev option, Kővágó, Zoltán, 2015/09/23
- [Qemu-devel] [PATCH v2 1/3] qapi: convert NumaOptions into a flat union, Kővágó, Zoltán, 2015/09/23
- Re: [Qemu-devel] [PATCH v2 1/3] qapi: convert NumaOptions into a flat union,
Eric Blake <=
- [Qemu-devel] [PATCH v2 2/3] qapi: change NetLegacy into a flat union, Kővágó, Zoltán, 2015/09/23
- [Qemu-devel] [PATCH v2 3/3] qapi: support nested structs in OptsVisitor, Kővágó, Zoltán, 2015/09/23