[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state |
Date: |
Wed, 23 Sep 2015 18:04:15 +0100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
* Amit Shah (address@hidden) wrote:
> On (Tue) 16 Jun 2015 [11:26:36], Dr. David Alan Gilbert (git) wrote:
>
> > - if (s->state == MIGRATION_STATUS_ACTIVE ||
> > - s->state == MIGRATION_STATUS_SETUP) {
> > + if (migration_already_active(s)) {
>
> (I know, not introduced here, but:)
>
> A better name is migration_is_active()
Done.
>
> > +bool migration_postcopy_phase(MigrationState *s)
> > +{
> > + return (s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE);
> > +}
>
> And this is better named migration_in_postcopy()
Done
>
> otherwise,
>
> Reviewed-by: Amit Shah <address@hidden>
>
>
>
> Amit
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state,
Dr. David Alan Gilbert <=