Re: [Qemu-devel] [PULL] remove libcacard

[Marc-André Lureau]

Hi

On Wed, Sep 23, 2015 at 7:22 PM, Peter Maydell <address@hidden> wrote:
> This fails to build (all platforms):
>
> /Users/pm215/src/qemu/hw/usb/ccid-card-passthru.c:15:10: fatal error:
> 'cacard/vscard_common.h' file not found
> #include "cacard/vscard_common.h"
>          ^
> 1 error generated.
>
> thanks
> -- PMM

Looks like our current Makefile didn't make this explicit enough, my
patch assumed that ccid-card-passthru.c didn't depend on libcacard
since:

 common-obj-y                          += ccid-card-passthru.o
-common-obj-$(CONFIG_SMARTCARD_NSS)    += ccid-card-emulated.o
-ccid-card-emulated.o-cflags := -I$(SRC_PATH)/libcacard
+common-obj-$(CONFIG_SMARTCARD)        += ccid-card-emulated.o

This works:
 common-obj-$(CONFIG_SMARTCARD)         += ccid-card-passthru.o

I am sending a new pull request.

-- 
Marc-André Lureau