[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 42/47] ivshmem: use strtosz()
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 42/47] ivshmem: use strtosz() |
|
Date: |
Thu, 24 Sep 2015 14:33:35 +0200 |
Hi
On Thu, Sep 24, 2015 at 2:13 PM, Marc-André Lureau
<address@hidden> wrote:
> scrap this one, it doesn't check the power of 2, and I wonder if
> accepting values lower than megabyte is acceptable
So the ivshmem server allows kilobytes shm, and with this patch, when
giving non-pow2 size to ivshmem device, you get the following error:
ERROR: PCI region size must be pow2 type=0xc, size=0xc00
This patch might be worth considering as is.
--
Marc-André Lureau
- [Qemu-devel] [PATCH v4 31/47] contrib: add ivshmem client and server, (continued)
- [Qemu-devel] [PATCH v4 31/47] contrib: add ivshmem client and server, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 35/47] docs: update ivshmem device spec, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 37/47] contrib: remove unnecessary strdup(), marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 38/47] msix: implement pba write (but read-only), marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 36/47] ivshmem: add check on protocol version in QEMU, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 39/47] qtest: add qtest_add_abrt_handler(), marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 40/47] tests: add ivshmem qtest, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 41/47] ivshmem: do not keep shm_fd open, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 42/47] ivshmem: use strtosz(), marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 44/47] ivshmem: remove EventfdEntry.vector, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 43/47] ivshmem: add hostmem backend, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 45/47] ivshmem: rename MSI eventfd_table, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 46/47] ivshmem: use kvm irqfd for msi notifications, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v4 47/47] ivshmem: use little-endian int64_t for the protocol, marcandre . lureau, 2015/09/24