[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 12/21] vhost-user: document migration log
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v5 12/21] vhost-user: document migration log |
Date: |
Thu, 24 Sep 2015 12:41:01 -0400 (EDT) |
Hi
----- Original Message -----
> On 09/24/2015 10:22 AM, address@hidden wrote:
> > From: Marc-André Lureau <address@hidden>
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> > docs/specs/vhost-user.txt | 48
> > +++++++++++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 46 insertions(+), 2 deletions(-)
>
> > @@ -140,8 +142,7 @@ Multiple queue support
> >
> > Multiple queue is treated as a protocol extension, hence the slave has to
> > implement protocol features first. The multiple queues feature is
> > supported
> > -only when the protocol feature VHOST_USER_PROTOCOL_F_MQ (bit 0) is set:
> > -#define VHOST_USER_PROTOCOL_F_MQ 0
> > +only when the protocol feature VHOST_USER_PROTOCOL_F_MQ (bit 0) is set.
>
> Should this hunk be in an earlier patch,
The series is on top of last Michael PULL request. I just moved the define
in a common section, since now they are 2 and later 3. Does that make sense?
>
> > +
> > +Protocol features
> > +-----------------
> > +
> > +#define VHOST_USER_PROTOCOL_F_MQ 0
> > +#define VHOST_USER_PROTOCOL_F_LOG_SHMFD 1
>
> along with this section (of course, with just bit 0 in that patch)?
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
>
- [Qemu-devel] [PATCH v5 03/21] util: add linux-only memfd fallback, (continued)
- [Qemu-devel] [PATCH v5 03/21] util: add linux-only memfd fallback, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 04/21] util: add memfd helpers, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 05/21] vhost: alloc shareable log, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 06/21] vhost: document log resizing, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 07/21] vhost: add vhost_set_log_base op, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 09/21] vhost-user: add a migration blocker, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 08/21] vhost-user: send log shm fd along with log_base, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 11/21] vhost: only use shared log if in use by backend, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 12/21] vhost-user: document migration log, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 13/21] net: add trace_vhost_user_event, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 10/21] vhost: use a function for each call, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 14/21] vhost user: add support of live migration, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 16/21] vhost-user-test: move wait_for_fds() out, marcandre . lureau, 2015/09/24
- [Qemu-devel] [PATCH v5 15/21] vhost user: add rarp sending after live migration for legacy guest, marcandre . lureau, 2015/09/24