[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/16] block: Get rid of bdrv_swap()
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH 00/16] block: Get rid of bdrv_swap() |
Date: |
Thu, 24 Sep 2015 20:32:11 +0200 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Thu 17 Sep 2015 03:48:04 PM CEST, Kevin Wolf wrote:
> bdrv_swap() has always been an ugly hack that we would rather have
> avoided. When it was introduced, we simply didn't have the
> infrastructure to update pointers instead of transplanting the
> contents of BDS object, so we grudgingly added bdrv_swap() as a quick
> solution. Meanwhile, most of the infrastructure exists and this
> series implements the final step necessary to implement the required
> functionality in a less adventurous way.
I managed to crash QEMU with this series. I don't think it's a problem
it the series itself, but rather some older bug that is triggered by
your patches.
I think I found the cause and I have a preliminary patch, I'll try to
send it tomorrow.
Berto
- [Qemu-devel] [PATCH 15/16] block: Add and use bdrv_replace_in_backing_chain(), (continued)