Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter

[Yang Hongyang]

On 09/24/2015 05:12 PM, Markus Armbruster wrote:
> Yang Hongyang <address@hidden> writes:
[...]
> > diff --git a/vl.c b/vl.c
> > index ec589e2..3cf89d5 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -2794,7 +2794,12 @@ static bool object_create_initial(const char *type)
> >       if (g_str_equal(type, "rng-egd")) {
> >           return false;
> >       }
> > -    /* TODO: return false for concrete netfilters */
> > +
> > +    /* return false for concrete netfilters */
>
> I find this comment useless, please drop it :)

This might be useful for reminding others who wants to implement other filters.

> > +    if (g_str_equal(type, "filter-buffer")) {
> > +        return false;
> > +    }
> > +
> >       return true;
> >   }
> .

--
Thanks,
Yang.