[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/7] device-introspect-test: New, covering de
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/7] device-introspect-test: New, covering device introspection |
Date: |
Fri, 25 Sep 2015 12:17:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 24/09/15 20:57, Markus Armbruster wrote:
> The test doesn't check that the output makes any sense, only that QEMU
> survives. Useful since we've had an astounding number of crash bugs
> around there.
>
> In fact, we have a bunch of them right now: several devices crash or
> hang, and all CPUs leave a dangling pointer behind. The test skips
> testing the broken parts. The next commits will fix them, and drop
> the skipping.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> tests/Makefile | 8 ++-
> tests/device-introspect-test.c | 153
> +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 158 insertions(+), 3 deletions(-)
> create mode 100644 tests/device-introspect-test.c
Hi Markus,
just a quick note: When I run the tester directly, it aborts:
$ tests/boot-order-test
**
ERROR:/home/thuth/devel/qemu/tests/libqtest.c:517:qtest_get_arch:
assertion failed: (qemu != NULL)
Aborted (core dumped)
... that's a little bit ugly, maybe you could print the help text instead?
Thomas
- [Qemu-devel] [PATCH v3 0/7] Fix device introspection regressions, Markus Armbruster, 2015/09/24
- [Qemu-devel] [PATCH v3 3/7] libqtest: New hmp() & friends, Markus Armbruster, 2015/09/24
- [Qemu-devel] [PATCH v3 1/7] tests: Fix how qom-test is run, Markus Armbruster, 2015/09/24
- [Qemu-devel] [PATCH v3 7/7] Revert "qdev: Use qdev_get_device_class() for -device <type>, help", Markus Armbruster, 2015/09/24
- [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices, Markus Armbruster, 2015/09/24