[Qemu-devel] [PATCH 26/36] qmp: check that async command have an 'id'

[marcandre . lureau]

From: Marc-André Lureau <address@hidden>

The async support mandates that request have an 'id' (see documentation
in following patch).

Signed-off-by: Marc-André Lureau <address@hidden>
---
 qapi/qmp-dispatch.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 83ecab5..73ba3ad 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -105,6 +105,11 @@ static QObject *do_qmp_dispatch(QObject *request, 
QmpReturn *qret, Error **errp)
         }
         break;
     case QCT_ASYNC:
+        if (!qdict_haskey(qret->rsp, "id")) {
+            error_setg(errp, "An async command requires an 'id'");
+            break;
+        }
+
         cmd->fn_async(args, qret);
         break;
     }
-- 
2.4.3