qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes
Date: Fri, 25 Sep 2015 08:30:23 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 09/25/2015 02:08 AM, Yang Hongyang wrote:
> This patchset addressed Markus comment on netfilter patch
> series, most of them are comment fixes.
> 
> It is based on jason's net tree:
> https://github.com/jasowang/qemu/tree/net

If that tree is not yet merged mainline, wouldn't it be better to squash
these fixes directly into the offending patches, instead of using it as
a followup patch?


>      /*
> -     * we return size when buffer a packet, the sender will take it as
> -     * a already sent packet, so sent_cb should not be called later
> -     * FIXME: even if guest can't receive packet for some reasons. Filter
> +     * We return size when buffer a packet, the sender will take it as
> +     * a already sent packet, so sent_cb should not be called later.

s/a already/an already/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]