qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/36] qapi: remove qmp-events.txt


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 09/36] qapi: remove qmp-events.txt
Date: Fri, 25 Sep 2015 09:40:55 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 09/25/2015 08:03 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> 
> Move the examples in the json file with the rest of the documentation to
> avoid duplication.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  docs/qmp/qmp-events.txt | 664 
> ------------------------------------------------
>  qapi/block-core.json    |  59 ++++-
>  qapi/block.json         |   9 +
>  qapi/event.json         | 206 +++++++++++++++
>  4 files changed, 272 insertions(+), 666 deletions(-)
>  delete mode 100644 docs/qmp/qmp-events.txt

Another big patch; not sure if it is worth splitting to ease review by
sharing the review load across multiple emails.  But not quite as
daunting as the qmp-commands.hx content move.  It will be a while before
I have a good stretch of time to commit to the actual review to make
sure nothing gets dropped, but I'm in favor of the idea.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]