Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: verify with user before quitting QEMU

[Peter Maydell]

On 23 September 2015 at 17:57, Programmingkid <address@hidden> wrote:
> This patch prevents the user from accidentally quitting QEMU by pushing
> Command-Q or by pushing the close button on the main window. When
> the user does one of these two things, a dialog box appears verifying
> with the user if he or she wants to quit QEMU.
>
> Signed-off-by: John Arbuckle <address@hidden>
>
> ---
> Replaced NSRunAlertPanel() with NSAlert.
> Added more informative comment to windowShouldClose: method.

Thanks, I have applied this to my cocoa.next branch.

Sending these as plain text has definitely helped with my
patch tool workflow, so thank you for sorting that out.
There is one more thing which you could fix which would mean
I could avoid another manual fixup: your From: address for these
emails is "Programmingkid <address@hidden>", which
means I have to manually edit the authorship of the git commit
to match up with your Signed-off-by: line. If you could make the
from match up with the signed-off-by line it would save me
having to do it at my end.

(If you use git format-patch/git send-email then it should
take the authorship from your local git commit, assuming you
have it correct there, and put a suitable From line in the
body of the mail in the right format so that it goes through
even if your from-line-for-email is different.)

thanks
-- PMM