[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 4/6] monitor: Turn monitor_qapi_event_state[] into
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC 4/6] monitor: Turn monitor_qapi_event_state[] into a hash table |
Date: |
Fri, 25 Sep 2015 13:21:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/25/2015 08:00 AM, Markus Armbruster wrote:
> In preparation of finer grained throttling.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> monitor.c | 55 ++++++++++++++++++++++++++++++++++++++-----------------
> 1 file changed, 38 insertions(+), 17 deletions(-)
>
> @@ -512,6 +518,14 @@ monitor_qapi_event_queue(QAPIEvent event, QDict *qdict,
> Error **errp)
> int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
>
> monitor_qapi_event_emit(event, qdict);
> +
> + evstate = g_new(MonitorQAPIEventState, 1);
> + evstate->event = event;
> + evstate->qdict = NULL;
> + evstate->timer = timer_new_ns(QEMU_CLOCK_REALTIME,
> + monitor_qapi_event_handler,
> + evstate);
Now timers are created and destroyed dynamically upon use rather than
reused and just waiting to be rearmed; I hope there aren't any obvious
inefficiencies from doing that.
The conversion looks sane:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC 0/6] Throttle event VSERPORT_CHANGE separately by "id", Markus Armbruster, 2015/09/25
- [Qemu-devel] [RFC 4/6] monitor: Turn monitor_qapi_event_state[] into a hash table, Markus Armbruster, 2015/09/25
- Re: [Qemu-devel] [RFC 4/6] monitor: Turn monitor_qapi_event_state[] into a hash table,
Eric Blake <=
- [Qemu-devel] [RFC 3/6] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState, Markus Armbruster, 2015/09/25
- [Qemu-devel] [RFC 1/6] monitor: Reduce casting of QAPI event QDict, Markus Armbruster, 2015/09/25
- [Qemu-devel] [RFC 2/6] monitor: Simplify event throttling, Markus Armbruster, 2015/09/25
- [Qemu-devel] [RFC 5/6] monitor: Throttle event VSERPORT_CHANGE separately by "id", Markus Armbruster, 2015/09/25