[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/digic: Fix memory leak reported by Cover
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/digic: Fix memory leak reported by Coverity |
Date: |
Fri, 25 Sep 2015 14:54:47 -0700 |
On 25 September 2015 at 12:55, Stefan Weil <address@hidden> wrote:
> Am 14.03.2015 um 11:19 schrieb Stefan Weil:
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>> hw/arm/digic_boards.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c
>> index 7114c36..ad70f7b 100644
>> --- a/hw/arm/digic_boards.c
>> +++ b/hw/arm/digic_boards.c
>> @@ -109,6 +109,7 @@ static void digic_load_rom(DigicBoardState *s, hwaddr
>> addr,
>> }
>>
>> rom_size = load_image_targphys(fn, addr, max_size);
>> + g_free(fn);
>> if (rom_size < 0 || rom_size > max_size) {
>> error_report("Couldn't load rom image '%s'.", filename);
>> exit(1);
>>
>
> Ping? Maybe this old patch can be applied to qemu-trivial.
>
> fn = qemu_find_file() allocates memory, so g_free is needed.
No, this was fixed by commit 6e05a12f8f7f32a3 so although this
patch still textually applies it would introduce a double-free.
thanks
-- PMM