[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] target-xtensa: xtfpga: attach FLASH to s
|
From: |
Max Filippov |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] target-xtensa: xtfpga: attach FLASH to system IO |
|
Date: |
Mon, 28 Sep 2015 00:58:22 +0300 |
On Mon, Sep 28, 2015 at 12:34 AM, Peter Crosthwaite
<address@hidden> wrote:
> On Sun, Sep 27, 2015 at 1:58 PM, Max Filippov <address@hidden> wrote:
>> + qdev_prop_set_uint16(dev, "id0", 0x00);
>> + qdev_prop_set_uint16(dev, "id1", 0x00);
>> + qdev_prop_set_uint16(dev, "id2", 0x00);
>> + qdev_prop_set_uint16(dev, "id3", 0x00);
>
> You can drop the ID setters to 0x00. That's the default. Otherwise:
>
> Reviewed-by: Peter Crosthwaite <address@hidden>
Ok.
> Something out of scope and possible follow-up: As these are real
> boards, ideally we have the ID for the actual parts populated. For
> ML605, the petalogix_ml605_mmu machine model does have this as
> non-zero.
So far there were no need in this level of detail.
--
Thanks.
-- Max