[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter |
Date: |
Mon, 28 Sep 2015 14:12:56 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/25/2015 11:07 PM, Markus Armbruster wrote:
> Yang Hongyang <address@hidden> writes:
>
>> On 09/24/2015 05:12 PM, Markus Armbruster wrote:
>>> Yang Hongyang <address@hidden> writes:
>>>
>>>> This filter is to buffer/release packets, this feature can be used
>>>> when using MicroCheckpointing, or other Remus like VM FT solutions, you
>>> What's "Remus"?
[...]
>>>
>>>> +
>>>> +static void filter_buffer_release_timer(void *opaque)
>>>> +{
>>>> + NetFilterState *nf = opaque;
>>>> + FilterBufferState *s = FILTER_BUFFER(nf);
>>> Style nit: blank line between declarations and statements, please.
>>>
>>>> + filter_buffer_flush(nf);
>>> Is purging correct here?
> When the timer expires, we flush as many buffered packets as we can,
> then throw away the rest. Why throw them away? Shouldn't we leave them
> in the buffer, and only throw away packets when the buffer is full?
May need a "FIXME" or "TODO" here. I think this is for simplicity. We
could queue the packet if the receiver or next filter could not receive
packets. But currently there's no way for the next filter or recivier to
notify us that it can receive more packet. This could be done in the future.
- Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support, (continued)
[Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Yang Hongyang, 2015/09/16
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Yang Hongyang, 2015/09/28
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Yang Hongyang, 2015/09/25
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Thomas Huth, 2015/09/25
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Yang Hongyang, 2015/09/25
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Markus Armbruster, 2015/09/25
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Yang Hongyang, 2015/09/28
[Qemu-devel] [PATCH v11 11/12] netfilter/multiqueue: introduce netfilter name, Yang Hongyang, 2015/09/16
Re: [Qemu-devel] [PATCH v11 00/12] Add a netfilter object and netbuffer filter, Jason Wang, 2015/09/22