Re: [Qemu-devel] [PULL 50/52] typedef: add typedef for QemuOpts

[Pavel Dovgaluk]

Thank you!

What about other patches from rr series?

Pavel Dovgalyuk

> -----Original Message-----
> From: Paolo Bonzini [mailto:address@hidden
> Sent: Friday, September 25, 2015 7:52 PM
> To: address@hidden
> Cc: Pavel Dovgalyuk; Pavel Dovgalyuk
> Subject: [PULL 50/52] typedef: add typedef for QemuOpts
> 
> From: Pavel Dovgalyuk <address@hidden>
> 
> This patch moves typedefs for QemuOpts and related types
> to qemu/typedefs.h file.
> 
> Reviewed-by: Paolo Bonzini <address@hidden>
> 
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  include/qemu/option.h   | 5 +----
>  include/qemu/typedefs.h | 3 +++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/qemu/option.h b/include/qemu/option.h
> index 57e51c9..71f5f27 100644
> --- a/include/qemu/option.h
> +++ b/include/qemu/option.h
> @@ -30,6 +30,7 @@
>  #include "qemu/queue.h"
>  #include "qapi/error.h"
>  #include "qapi/qmp/qdict.h"
> +#include "qemu/typedefs.h"
> 
>  const char *get_opt_name(char *buf, int buf_size, const char *p, char delim);
>  const char *get_opt_value(char *buf, int buf_size, const char *p);
> @@ -44,10 +45,6 @@ void parse_option_size(const char *name, const char *value,
>  bool has_help_option(const char *param);
>  bool is_valid_option_list(const char *param);
> 
> -typedef struct QemuOpt QemuOpt;
> -typedef struct QemuOpts QemuOpts;
> -typedef struct QemuOptsList QemuOptsList;
> -
>  enum QemuOptType {
>      QEMU_OPT_STRING = 0,  /* no parsing (use string as-is)                   
>      */
>      QEMU_OPT_BOOL,        /* on/off                                          
>      */
> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> index ce82c64..3a835ff 100644
> --- a/include/qemu/typedefs.h
> +++ b/include/qemu/typedefs.h
> @@ -67,6 +67,9 @@ typedef struct Property Property;
>  typedef struct QEMUBH QEMUBH;
>  typedef struct QemuConsole QemuConsole;
>  typedef struct QEMUFile QEMUFile;
> +typedef struct QemuOpt QemuOpt;
> +typedef struct QemuOpts QemuOpts;
> +typedef struct QemuOptsList QemuOptsList;
>  typedef struct QEMUSGList QEMUSGList;
>  typedef struct QEMUSizedBuffer QEMUSizedBuffer;
>  typedef struct QEMUTimerListGroup QEMUTimerListGroup;
> --
> 2.5.0
>