[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/47] ivshmem: remove last exit(1)
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/47] ivshmem: remove last exit(1) |
Date: |
Tue, 29 Sep 2015 14:43:10 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 24.09.2015 13:37, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Failing to create a chardev shouldn't be fatal.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> hw/misc/ivshmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 62547c0..e7224b9 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -299,7 +299,7 @@ static CharDriverState* create_eventfd_chr_device(void *
> opaque, EventNotifier *
>
> if (chr == NULL) {
> error_report("creating eventfd for eventfd %d failed", eventfd);
> - exit(1);
> + return NULL;
> }
> qemu_chr_fe_claim_no_fail(chr);
>
>
Reviewed-by: Claudio Fontana <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 10/47] ivshmem: remove last exit(1),
Claudio Fontana <=