[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 03/47] ivhsmem: read do not accept more than
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH v4 03/47] ivhsmem: read do not accept more than sizeof(long) |
Date: |
Tue, 29 Sep 2015 15:15:23 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 24.09.2015 13:37, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> ivshmem_read() only reads sizeof(long) from the input buffer. Accepting
> more could lead to fifo8 abort() on 32bit systems if fifo is not empty.
>
> A following patch will change the protocol to 64-bit little-endian
> instead.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> hw/misc/ivshmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index cc76989..fb53b3f 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -272,7 +272,7 @@ static void ivshmem_receive(void *opaque, const uint8_t
> *buf, int size)
>
> static int ivshmem_can_receive(void * opaque)
> {
> - return 8;
> + return sizeof(long);
> }
>
> static void ivshmem_event(void *opaque, int event)
>
agreed in light of the successive patch
Reviewed-by: Claudio Fontana <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 03/47] ivhsmem: read do not accept more than sizeof(long),
Claudio Fontana <=