qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 10/16] qapi: Consistent generated code: prefe


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v6 10/16] qapi: Consistent generated code: prefer error 'err'
Date: Tue, 29 Sep 2015 15:46:46 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> We had some pointless differences in the generated code for visit,
> command marshalling, and events; unifying them makes it easier for
> future patches to consolidate to common helper functions.
>
> This is patch 1/4, focusing on naming the local error variable
> 'err' rather than 'local_err'.

Suggest "is the first of four patches", to avoid any confusion with the
numbering of patches within the series.  Likewise for the other three.

>
> No change in semantics to the generated code.
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v6: split 9/46 into four patches, update docs where they are affected,
> rebase with 7/46 placed later in series

Review is now boring.  That's good :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]