Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected

[Gerd Hoffmann]

  Hi,

> what about Recycling the output buffer as worker thread buffer?

You can't do that as vs is allocated on the stack, therefore not valid
any more when vnc_worker_thread_loop returns.


> about shrinking: I had the idea to count the number of times the buffer was 
> (significantly) too big and only shrink if that counter has reached a 
> reasonable value. and reset that counter to zero if the buffer has the right 
> size.
> 
> i would check this in qio_buffer_resize. as you suggested earlier.

Not sure whenever it is a good idea to do that on every reserve call.
Maybe better place shrink calls in places where you know it is worth
checking, to have lower overhead.

Patches are welcome in any case ;)

cheers,
  Gerd