Re: [Qemu-devel] [PATCH] kvm-unit-tests: arm: Fail on unknown subtest

[Andrew Jones]

On Tue, Sep 29, 2015 at 11:08:27AM -0400, Christopher Covington wrote:
> Signed-off-by: Christopher Covington <address@hidden>
> ---
>  arm/selftest.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arm/selftest.c b/arm/selftest.c
> index fc9ec60..aa16a91 100644
> --- a/arm/selftest.c
> +++ b/arm/selftest.c
> @@ -376,6 +376,8 @@ int main(int argc, char **argv)
>               cpumask_set_cpu(0, &smp_reported);
>               while (!cpumask_full(&smp_reported))
>                       cpu_relax();
> +     } else {
> +             report("Unknown subtest", false);

I think

 printf("Unknown subtest\n");
 abort();

might be better. Also, please post kvm-unit-tests patches to the
kvm mailing list.

Thanks,
drew

>       }
>  
>       return report_summary();
> -- 
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>