[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/2] target-i386: Don't left shift negative constant
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 2/2] target-i386: Don't left shift negative constant |
Date: |
Tue, 29 Sep 2015 17:34:23 -0300 |
Left shift of negative values is undefined behavior. Detected by clang:
qemu/target-i386/translate.c:2423:26: runtime error:
left shift of negative value -8
This changes the code to reverse the sign after the left shift.
Signed-off-by: Eduardo Habkost <address@hidden>
---
target-i386/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 8b35de1..cc59b7e 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -2420,7 +2420,7 @@ static void gen_pusha(DisasContext *s)
{
int i;
gen_op_movl_A0_reg(R_ESP);
- gen_op_addl_A0_im(-8 << s->dflag);
+ gen_op_addl_A0_im(-(8 << s->dflag));
if (!s->ss32)
tcg_gen_ext16u_tl(cpu_A0, cpu_A0);
tcg_gen_mov_tl(cpu_T[1], cpu_A0);
--
2.1.0
- Re: [Qemu-devel] [PATCH 1/2] target-i386: Use 1UL for bit shift, (continued)
- Re: [Qemu-devel] [PATCH 1/2] target-i386: Use 1UL for bit shift, Peter Maydell, 2015/10/08
- Re: [Qemu-devel] [PATCH 1/2] target-i386: Use 1UL for bit shift, Markus Armbruster, 2015/10/08
- Re: [Qemu-devel] [PATCH 1/2] target-i386: Use 1UL for bit shift, Laszlo Ersek, 2015/10/08
- Re: [Qemu-devel] [PATCH 1/2] target-i386: Use 1UL for bit shift, Paolo Bonzini, 2015/10/08
- Re: [Qemu-devel] [PATCH 1/2] target-i386: Use 1UL for bit shift, Laszlo Ersek, 2015/10/08
- Re: [Qemu-devel] [PATCH 1/2] target-i386: Use 1UL for bit shift, Paolo Bonzini, 2015/10/08
- Re: [Qemu-devel] [PATCH 1/2] target-i386: Use 1UL for bit shift, Kevin O'Connor, 2015/10/08
[Qemu-devel] [PATCH 2/2] target-i386: Don't left shift negative constant,
Eduardo Habkost <=