[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3 4/7] vfio: Record host IOMMU's available IO pa
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCHv3 4/7] vfio: Record host IOMMU's available IO page sizes |
Date: |
Wed, 30 Sep 2015 10:27:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 30/09/2015 04:13, David Gibson wrote:
> Depending on the host IOMMU type we determine and record the available page
> sizes for IOMMU translation. We'll need this for other validation in
> future patches.
>
> Signed-off-by: David Gibson <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> Reviewed-by: Laurent Vivier <address@hidden>
> ---
> hw/vfio/common.c | 13 +++++++++++++
> include/hw/vfio/vfio-common.h | 1 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index 2faf492..f666de2 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -677,6 +677,7 @@ static int vfio_connect_container(VFIOGroup *group,
> AddressSpace *as)
> if (ioctl(fd, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU) ||
> ioctl(fd, VFIO_CHECK_EXTENSION, VFIO_TYPE1v2_IOMMU)) {
> bool v2 = !!ioctl(fd, VFIO_CHECK_EXTENSION, VFIO_TYPE1v2_IOMMU);
> + struct vfio_iommu_type1_info info;
>
> ret = ioctl(group->fd, VFIO_GROUP_SET_CONTAINER, &fd);
> if (ret) {
> @@ -702,6 +703,15 @@ static int vfio_connect_container(VFIOGroup *group,
> AddressSpace *as)
> */
> container->min_iova = 0;
> container->max_iova = (hwaddr)-1;
> +
> + /* Assume just 4K IOVA page size */
> + container->iova_pgsizes = 0x1000;
> + info.argsz = sizeof(info);
> + ret = ioctl(fd, VFIO_IOMMU_GET_INFO, &info);
> + /* Ignore errors */
> + if ((ret == 0) && (info.flags & VFIO_IOMMU_INFO_PGSIZES)) {
> + container->iova_pgsizes = info.iova_pgsizes;
> + }
> } else if (ioctl(fd, VFIO_CHECK_EXTENSION, VFIO_SPAPR_TCE_IOMMU)) {
> struct vfio_iommu_spapr_tce_info info;
>
> @@ -744,6 +754,9 @@ static int vfio_connect_container(VFIOGroup *group,
> AddressSpace *as)
> }
> container->min_iova = info.dma32_window_start;
> container->max_iova = container->min_iova + info.dma32_window_size -
> 1;
> +
> + /* Assume just 4K IOVA pages for now */
> + container->iova_pgsizes = 0x1000;
> } else {
> error_report("vfio: No available IOMMU models");
> ret = -EINVAL;
> diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
> index 27a14c0..f037f3c 100644
> --- a/include/hw/vfio/vfio-common.h
> +++ b/include/hw/vfio/vfio-common.h
> @@ -71,6 +71,7 @@ typedef struct VFIOContainer {
> * future
> */
> hwaddr min_iova, max_iova;
> + uint64_t iova_pgsizes;
> QLIST_HEAD(, VFIOGuestIOMMU) giommu_list;
> QLIST_HEAD(, VFIOGroup) group_list;
> QLIST_ENTRY(VFIOContainer) next;
>
Reviewed-by: Laurent Vivier <address@hidden>
- Re: [Qemu-devel] [PATCHv3 6/7] vfio: Allow hotplug of containers onto existing guest IOMMU mappings, (continued)
- [Qemu-devel] [PATCHv3 1/7] vfio: Remove unneeded union from VFIOContainer, David Gibson, 2015/10/08
- [Qemu-devel] [PATCHv3 3/7] vfio: Check guest IOVA ranges against host IOMMU capabilities, David Gibson, 2015/10/08
- Re: [Qemu-devel] [PATCHv3 0/7] VFIO extensions to allow VFIO devices on spapr-pci-host-bridge, Alex Williamson, 2015/10/08
- [Qemu-devel] [PATCHv3 2/7] vfio: Generalize vfio_listener_region_add failure path, David Gibson, 2015/10/08
- [Qemu-devel] [PATCHv3 4/7] vfio: Record host IOMMU's available IO page sizes, David Gibson, 2015/10/08
- Re: [Qemu-devel] [PATCHv3 4/7] vfio: Record host IOMMU's available IO page sizes,
Laurent Vivier <=