qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] target-tilegx: Support iret instruction and


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v3] target-tilegx: Support iret instruction and related special registers
Date: Fri, 2 Oct 2015 12:26:59 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 10/02/2015 11:31 AM, Chris Metcalf wrote:

It disables interrupts from being delivered.  This means asynchronous
interrupts get deferred until ICS is set back to zero, and synchronous
interrupts (page fault, etc) cause a double-fault instead. ICS is automatically
set on entry to interrupt handlers, so the handler has time to acquire any
information about the interrupt from SPRs, and it is expected that ICS is
cleared as soon as possible.  ICS can also be used before returning from
interrupts if you need to do something like adjust the interrupt mask prior to
returning.

Which is all very well and good for supervisor mode... but what's it good for in user mode?

I was about to quote you from 2012 (https://lkml.org/lkml/2012/3/30/994):

In general we want to avoid ever touching memory while within an
interrupt critical section, since the page fault path goes through
a different path from the hypervisor when in an interrupt critical
section, and we carefully decided with tilegx that we didn't need
to support this path in the kernel.

Which implies that tilegx userland does nothing at all with ICS, and is in fact unsupported?


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]