Re: [Qemu-devel] [PATCH 0/3] exec: Collect CPU's AddressSpace info into its own struct

[Peter Maydell]

On 3 July 2015 at 16:11, Peter Maydell <address@hidden> wrote:
> This patchset is a bit of groundwork heading in the direction
> of supporting multiple AddressSpaces per CPU. It does actually
> do something useful (handle a FIXME remark in tcg_commit()) so
> I've put it out for that reason and for some early comments.
>
> Patch 1 is just removing an unnecessary call to cpu_reload_memory_map()
> to make the cleanup a bit easier.
> Patch 2 is a comment change which I hope Paolo will review to tell
> me if I've misunderstood things :-)
> Patch 3 is the actual work here: we collect up the fields that
> were directly in CPUState but relating to our one-and-only
> AddressSpace, and put them in a new struct CPUAddressSpace
> CPUState now has a pointer to an array of these (with only one
> entry for now). The rearrangement lets us fix the tcg_commit()
> FIXME remark by going directly to the affected CPUState from
> the MemoryListener pointer rather than having to search all CPUs
> for it.
>
> CPUState::as remains, as a convenience pointer to the first
> AddressSpace we know about for the benefit of all the targets
> which only have one AS per CPU.

Paolo, would you take (a rebased version of) this series as it
stands, on the basis that it fixes that FIXME about the MemoryListener?
Or do you want more of an actual use case for it first?

(I've done the rebase, just wondering if it's worth sending out
again yet.)

thanks
-- PMM