Re: [Qemu-devel] [PULL 00/10] VFIO updates for 2015-10-05

[David Gibson]

On Tue, Oct 06, 2015 at 09:35:17AM -0600, Alex Williamson wrote:
> On Tue, 2015-10-06 at 15:50 +0100, Peter Maydell wrote:
> > On 5 October 2015 at 21:36, Alex Williamson <address@hidden> wrote:
> > > The following changes since commit 
> > > c0b520dfb8890294a9f8879f4759172900585995:
> > >
> > >   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into 
> > > staging (2015-10-02 16:59:21 +0100)
> > >
> > > are available in the git repository at:
> > >
> > >
> > >   git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20151005.0
> > >
> > > for you to fetch changes up to 727299697dd31f0e1ccecc7eab1bf658e8ed3079:
> > >
> > >   vfio: Expose a VFIO PCI device's group for EEH (2015-10-05 12:40:13 
> > > -0600)
> > >
> > > ----------------------------------------------------------------
> > > VFIO updates 2015-10-05
> > >
> > >  - Change platform device IRQ setup sequence for compatibility
> > >    with upcoming IRQ forwarding (Eric Auger)
> > >  - Extensions to support vfio-pci devices on spapr-pci-host-bridge
> > >    (David Gibson)
> > >
> > > ----------------------------------------------------------------
> > 
> > Hi. I'm afraid this fails to build with clang:
> > 
> > In file included from 
> > /home/petmay01/linaro/qemu-for-merges/hw/vfio/pci.c:38:
> > /home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-pci.h:7:26:
> > error: redefinition of typedef 'VFIOGroup' is a C11 feature
> > [-Werror,-Wtypedef-redefinition]
> > typedef struct VFIOGroup VFIOGroup;
> >                          ^
> > /home/petmay01/linaro/qemu-for-merges/include/hw/vfio/vfio-common.h:117:3:
> > note: previous definition is here
> > } VFIOGroup;
> >   ^
> > 1 error generated.
> 
> Thanks Peter.  David, can you send a replacement for that last patch?
> Thanks,

Actually, can you just drop the last patch for now.

The use case I thought I had for it turns out not to be.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature