Re: [Qemu-devel] [PATCH v3 6/6] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ

[Richard Henderson]

On 10/07/2015 09:34 PM, James Hogan wrote:
> > >       { INDEX_op_brcond_i32, { "rZ", "rZ" } },
> > > +#if !use_mips32r6_instructions
> > >       { INDEX_op_movcond_i32, { "r", "rZ", "rZ", "rZ", "0" } },
> > > +#else
> > > +    { INDEX_op_movcond_i32, { "r", "rZ", "rZ", "rZ", "rZ" } },
> > > +#endif
> >
> >
> > The only thing I'd change is preferring positive tests to negative ones.  So
> > swap the order of these lines, and the sense of the #if.
>
> No problem. Shall I do a full resend for that, or can it be fixed up by
> whoever applies?

No resend needed.  I'll fix it when applying to my tcg queue.


r~