[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary varia
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable |
Date: |
Mon, 05 Oct 2015 07:18:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Michael Tokarev <address@hidden> writes:
> 25.09.2015 11:37, Shraddha Barke wrote:
>> Compress lines and remove the variable .
>
> Applied to -trivial, removing this piece of commit message:
>
> ---
>> Change made using Coccinelle script
>>
>> @@
>> expression ret;
>> @@
>> - if (ret) return ret;
>> - return 0;
>> + return ret;
>> @@
>> local idexpression ret;
>> expression e;
>> @@
>> - ret = e;
>> - return ret;
>> + return e;
>> @@
>> type T; identifier i;
>> @@
>> - T i;
>> ... when != i
> ---
Why? I like having the semantic patch in the commit message when
there's any chance we'll want do the same mechanical change again later.
You could save space and include it by reference, though: "Same
Coccinelle semantic patch as is commit 74c373e".