Re: [Qemu-devel] [PATCH v5 13/46] qapi: Track owner of each object member

[Eric Blake]

On 09/21/2015 03:57 PM, Eric Blake wrote:

> 
> Where implicit types are involved, the code intentionally tries
> to pick the name of the owner of that implicit type, rather than
> the type name itself (a user reading the error message should be
> able to grep for the problem in their original file, but will not
> be able to locate a generated implicit name).  For simple unions,
> I chose not to pass the union name to the variants constructor;
> but this should be okay because in practice nothing should ever
> conflict with the implicit 'type' of a simple union.

This last sentence is false; I later discovered that we can indeed have
collisions with a branch named 'type' (see v6 subset A 6/16). So I'll
probably have to adjust this a bit.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature