Re: [Qemu-devel] [PATCH v12 00/10] Add a netfilter object and netbuffer filter

[Markus Armbruster]

Yang Hongyang <address@hidden> writes:

> This patch add an netfilter abstract object, captures all network packets
> on associated netdev. Also implement a concrete filter buffer based on
> this abstract object. the "buffer" netfilter could be used by VM FT solutions
> like MicroCheckpointing, to buffer/release packets. Or to simulate
> packet delay.
>
> You can also get the series from:
> https://github.com/macrosheep/qemu/tree/netfilter-v12
>
> Usage:
>  -netdev tap,id=bn0
>  -device e1000,netdev=bn0
>  -object filter-buffer,id=f0,netdev=bn0,queue=rx,interval=1000
>
> dynamically add/remove netfilters:
>  object_add filter-buffer,id=f0,netdev=bn0,queue=rx,interval=1000
>  object_del f0
>
> NOTE:
>  interval is in microseconds and can't be omiited.
>  queue is optional, and is one of rx|tx|all, default is "all". See
>  enum NetFilterDirection for detail.

I reviewed the patches touching the QAPI schema or the command line.
Only a few simple issues left.  One more respin should do it.