qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/6] disas/mips: Add R6 jr/jr.hb to disassemb


From: Leon Alrae
Subject: Re: [Qemu-devel] [PATCH v2 2/6] disas/mips: Add R6 jr/jr.hb to disassembler
Date: Fri, 2 Oct 2015 10:19:11 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 01/10/15 11:58, James Hogan wrote:
> @@ -2420,9 +2420,11 @@ const struct mips_opcode mips_builtin_opcodes[] =
>  {"hibernate","",        0x42000023, 0xffffffff,      0,                      
> 0,              V1      },
>  {"ins",     "t,r,+A,+B", 0x7c000004, 0xfc00003f, WR_t|RD_s,                  
> 0,              I33     },
>  {"jr",      "s",     0x00000008, 0xfc1fffff, UBD|RD_s,               0,      
>         I1      },
> +{"jr",      "s",     0x00000009, 0xfc1fffff, UBD|RD_s,               0,      
>         I32R6   }, /* jalr */
>  /* jr.hb is officially MIPS{32,64}R2, but it works on R1 as jr with
>     the same hazard barrier effect.  */
>  {"jr.hb",   "s",     0x00000408, 0xfc1fffff, UBD|RD_s,               0,      
>         I32     },
> +{"jr.hb",   "s",     0x00000408, 0xfc1fffff, UBD|RD_s,               0,      
>         I32R6   }, /* jalr.hb */

jr.hb match should be 0x00000409, otherwise:

Reviewed-by: Leon Alrae <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]