qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/4] firmware: introduce sysfs driver for QEM


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v3 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device
Date: Tue, 6 Oct 2015 09:40:42 +0100
User-agent: Mutt/1.5.24 (2015-08-30)

On Sat, Oct 03, 2015 at 07:28:06PM -0400, Gabriel L. Somlo wrote:
> +/* read chunk of given fw_cfg blob (caller responsible for sanity-check) */
> +static inline void fw_cfg_read_blob(u16 key,
> +                                 void *buf, loff_t pos, size_t count)
> +{
> +     mutex_lock(&fw_cfg_dev_lock);
> +     iowrite16(fw_cfg_sel_endianness(key), fw_cfg_reg_ctrl);
> +     while (pos-- > 0)
> +             ioread8(fw_cfg_reg_data);
> +     ioread8_rep(fw_cfg_reg_data, buf, count);
> +     mutex_unlock(&fw_cfg_dev_lock);
> +}

Have you had a chance to play with Marc Mari's fw_cfg DMA interface
patches?  They should make this operation much faster.

https://www.mail-archive.com/address@hidden/msg325541.html

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]