Re: [Qemu-devel] [PULL 00/48] ivshmem series

[Marc-André Lureau]

Hi

----- Original Message -----
> Drew,
> 
> Am 07.10.2015 um 14:42 schrieb Andrew Jones:
> > On Wed, Oct 07, 2015 at 08:16:40AM -0400, Marc-André Lureau wrote:
> >> ----- Original Message -----
> >>> Am 06.10.2015 um 21:18 schrieb address@hidden:
> >>>> Marc-André Lureau (45):
> >>> [...]
> >>>>       tests: add ivshmem qtest
> >>>
> >>> I had NAK'ed this patch in v1 and it has not been fixed. If this pull
> >>> gets merged I will immediately revert it. Not funny.
> >>>
> >>
> >>
> >> Could stick to technical review, please. The test runs fine without kvm.
> >> Regarding your copyright claim, I already explain that your older version
> >> of boilerplate test is really nothing compare to this one. But if you
> >> feel so strongly about it, I don't care you add a copyright line.
> >>
> > 
> > I would care if we added it. If contributors are getting bullied into
> > outrageous demands, then there's something wrong. Something wrong is
> > something we should try to fix, not just shrug off. And, in this case,
> > Andreas' claim is quite outrageous. The patch[*] in question provided
> > absolutely nothing that couldn't have been copy+pasted from any other
> > qtest.
> 
> If something is outrageous, then the way Marc-André is bullying *me* by
> 1) spinning his own version of my tests/ivshmem-test.c (not just copying

It doesn't share anything but boilerplate qtest code. Btw, do you have a 
non-RFC version of this patch?

> boilerplate from somewhere else), 2) spinning his own version of my
> "make test" patch (which Peter keeps refusing to apply for two releases

which patch are you talking about precisely here?

> now) and 3) trying to sneak QOM changes in via trivial without CC'ing
> me. Who knows what else I've missed. It's a recurring pattern.

That's a mistake from me for removing a comment that I thought was trivial, and 
forgot to CC the maintainer of the file too.

Let's not mix unrelated things here.

> I don't currently have as much time for upstream QEMU as I'd like, so
> other people either ignoring the work that I did do or taking my work
> and pretending that it is their own is truely offending to me. It was an
> easy-to-address review comment that hardly qualifies as bullying - after
> all he is also taking patches from 6wind.com properly.

I don't think anyone is trying to offend you. However, since I am quite new to 
the qemu project, it's understandable I make mistakes. Please try to be a bit 
more friendly with newcomers.

> I note that you are redhat.com, too.

:)

cheers