[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 17/48] ivshmem: improve debug messages
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH v5 17/48] ivshmem: improve debug messages |
Date: |
Mon, 5 Oct 2015 12:28:22 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 02.10.2015 21:09, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Some misc improvements to ivshmem debug.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Claudio Fontana <address@hidden>
> ---
> hw/misc/ivshmem.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index c4c130d..50f9c8f 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -208,10 +208,13 @@ static void ivshmem_io_write(void *opaque, hwaddr addr,
> if (vector < s->peers[dest].nb_eventfds) {
> IVSHMEM_DPRINTF("Notifying VM %d on vector %d\n", dest,
> vector);
> event_notifier_set(&s->peers[dest].eventfds[vector]);
> + } else {
> + IVSHMEM_DPRINTF("Invalid destination vector %d on VM %d\n",
> + vector, dest);
> }
> break;
> default:
> - IVSHMEM_DPRINTF("Invalid VM Doorbell VM %d\n", dest);
> + IVSHMEM_DPRINTF("Unhandled write " TARGET_FMT_plx "\n", addr);
> }
> }
>
> @@ -263,9 +266,9 @@ static void ivshmem_receive(void *opaque, const uint8_t
> *buf, int size)
> {
> IVShmemState *s = opaque;
>
> - ivshmem_IntrStatus_write(s, *buf);
> + IVSHMEM_DPRINTF("ivshmem_receive 0x%02x size: %d\n", *buf, size);
>
> - IVSHMEM_DPRINTF("ivshmem_receive 0x%02x\n", *buf);
> + ivshmem_IntrStatus_write(s, *buf);
> }
>
> static int ivshmem_can_receive(void * opaque)
> @@ -592,6 +595,7 @@ static void ivshmem_use_msix(IVShmemState * s)
> PCIDevice *d = PCI_DEVICE(s);
> int i;
>
> + IVSHMEM_DPRINTF("%s, msix present: %d\n", __func__, msix_present(d));
> if (!msix_present(d)) {
> return;
> }
>
- [Qemu-devel] [PATCH v5 00/48] ivshmem improvements, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 02/48] msix: add VMSTATE_MSIX_TEST, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 22/48] ivshmem: use common is_power_of_2(), marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 11/48] ivshmem: limit maximum number of peers to G_MAXUINT16, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 23/48] ivshmem: migrate with VMStateDescription, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 17/48] ivshmem: improve debug messages, marcandre . lureau, 2015/10/08
- Re: [Qemu-devel] [PATCH v5 17/48] ivshmem: improve debug messages,
Claudio Fontana <=
- [Qemu-devel] [PATCH v5 26/48] ivshmem: add device description, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 34/48] ivshmem-server: fix hugetlbfs support, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 24/48] ivshmem: shmfd can be 0, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 29/48] ivshmem: error on too many eventfd received, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 33/48] ivshmem-server: use a uint16 for client ID, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 31/48] contrib: add ivshmem client and server, marcandre . lureau, 2015/10/08
- [Qemu-devel] [PATCH v5 36/48] ivshmem: add check on protocol version in QEMU, marcandre . lureau, 2015/10/08