qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions
Date: Mon, 5 Oct 2015 21:27:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0


On 05/10/2015 20:46, Peter Maydell wrote:
> The easy fix is to have some suitable ifdeffery in virtio-pci.c,
> similar to how we only register the virtio_9p_pci and virtio_scsi_pci

(vhost_scsi_pci)

> types if they've been configured into this build.

Hmm, actually there's no reason to limit

common-obj-$(CONFIG_VIRTIO) += virtio-input.o
common-obj-$(CONFIG_VIRTIO) += virtio-input-hid.o

to CONFIG_LINUX.  Does it work to extract them out of the if (which is
only correct for virtio-input-host.o)?

That said, the ifdeffery _is_ needed for TYPE_VIRTIO_INPUT_HOST_PCI.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]