[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions |
Date: |
Mon, 5 Oct 2015 21:27:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/10/2015 20:46, Peter Maydell wrote:
> The easy fix is to have some suitable ifdeffery in virtio-pci.c,
> similar to how we only register the virtio_9p_pci and virtio_scsi_pci
(vhost_scsi_pci)
> types if they've been configured into this build.
Hmm, actually there's no reason to limit
common-obj-$(CONFIG_VIRTIO) += virtio-input.o
common-obj-$(CONFIG_VIRTIO) += virtio-input-hid.o
to CONFIG_LINUX. Does it work to extract them out of the if (which is
only correct for virtio-input-host.o)?
That said, the ifdeffery _is_ needed for TYPE_VIRTIO_INPUT_HOST_PCI.
Paolo
- [Qemu-devel] [PULL 04/10] tests: Fix how qom-test is run, (continued)
- [Qemu-devel] [PULL 04/10] tests: Fix how qom-test is run, Markus Armbruster, 2015/10/08
- [Qemu-devel] [PULL 09/10] qdev: Protect device-list-properties against broken devices, Markus Armbruster, 2015/10/08
- [Qemu-devel] [PULL 01/10] memory: allow destroying a non-empty MemoryRegion, Markus Armbruster, 2015/10/08
- [Qemu-devel] [PULL 06/10] libqtest: New hmp() & friends, Markus Armbruster, 2015/10/08
- [Qemu-devel] [PULL 03/10] macio: move DBDMA_init from instance_init to realize, Markus Armbruster, 2015/10/08
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions, Peter Maydell, 2015/10/08
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions, Markus Armbruster, 2015/10/08
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions, Peter Maydell, 2015/10/08
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions, Markus Armbruster, 2015/10/08
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions, Peter Maydell, 2015/10/08
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions, Peter Maydell, 2015/10/08
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions, Markus Armbruster, 2015/10/08
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions, Peter Maydell, 2015/10/08
- Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions, Markus Armbruster, 2015/10/08