Re: [Qemu-devel] [PATCH] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

[Peter Maydell]

On 5 October 2015 at 20:06, nutanshinde1992 <address@hidden> wrote:
> ---
>  hw/audio/adlib.c  |  9 ++-------
>  hw/audio/es1370.c | 17 ++++++-----------
>  hw/audio/gus.c    |  9 ++-------
>  hw/audio/sb16.c   | 15 +++++----------
>  4 files changed, 15 insertions(+), 35 deletions(-)

Hi; thanks for sending us this patch. Codewise the changes
look good; there's just a minor coding style nit, and a process
issue you need to deal with.

The process issue is that your git commit message has to
end with a 'Signed-off-by: Your Name <address@hidden>' line.
(If you look in the git commit logs at other peoples' changes you'll
see what I mean.)

This is you certifying to us that you wrote the patch and are
willing to submit it to us under the terms of QEMU's license.
(For a full statement of what you're signing to say, look here:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297
 -- we use the same idea as the Linux kernel for this.)

> diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c
> index 656eb37..af39920 100644
> --- a/hw/audio/adlib.c
> +++ b/hw/audio/adlib.c
> @@ -57,11 +57,6 @@ void YMF262UpdateOneQEMU (int which, INT16 *dst, int 
> length);
>  #define SHIFT 1
>  #endif
>
> -#define IO_READ_PROTO(name) \
> -    uint32_t name (void *opaque, uint32_t nport)
> -#define IO_WRITE_PROTO(name) \
> -    void name (void *opaque, uint32_t nport, uint32_t val)
> -
>  #define TYPE_ADLIB "adlib"
>  #define ADLIB(obj) OBJECT_CHECK(AdlibState, (obj), TYPE_ADLIB)
>
> @@ -124,7 +119,7 @@ static void adlib_kill_timers (AdlibState *s)
>      }
>  }
>
> -static IO_WRITE_PROTO (adlib_write)
> +static void adlib_write (void *opaque, uint32_t nport, uint32_t val)

The style issue is that all these functions should not have a
space between the function name and the '('.

If you could remove the stray spaces, and then send us the
fixed patch again with your signoff line in the commit message,
that would be great. (Make sure the subject line says "[PATCH v2]"
so we know it's the revised version.)

thanks
-- PMM