[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] block: switch from g_slice allocat
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] block: switch from g_slice allocator to malloc |
|
Date: |
Thu, 8 Oct 2015 11:41:17 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 08.10.2015 um 10:54 hat Stefan Hajnoczi geschrieben:
> On Thu, Oct 01, 2015 at 01:04:39PM +0200, Paolo Bonzini wrote:
> > Simplify memory allocation by sticking with a single API. GSlice
> > is not that fast anyway (tcmalloc/jemalloc are better).
> >
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > ---
> > block/io.c | 4 ++--
> > block/mirror.c | 4 ++--
> > block/raw-posix.c | 8 ++++----
> > block/raw-win32.c | 4 ++--
> > hw/block/virtio-blk.c | 4 ++--
> > 5 files changed, 12 insertions(+), 12 deletions(-)
>
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block
Has someone benchmarked this before applying? Just claiming "wasn't fast
anyway" doesn't generally seem sufficient for changes to the I/O path.
Kevin